Well I registered just to answer this post

. I play High elves for about 9 years now, so hopefully ill be able to help a bit.
First of all I would reconsider your hero choices, especially picking a lord (either archmage if you are going for a magic heavy army, or a prince for ld 10) If you are going for a prince it\'s probably best to field him on a stardragon (which is the hardest hitting thing you may field). I personally use prince on a dragon with lance, armour of caledor, vambraces of defence and amulet of light (against all those pesky wraiths, and demons). So i\'d swap korhil or caldyryan for a custom made lord.
As for core units - high elves with super awesome Speed of Asuryan are really tough in combat, but are really fragile to enemy shooting. But that can be quite easily solved by fielding archers (we use them to shoot enemy archers, as our units are more than capable of destroying the rest of enemy army) I personally field 2 ten man units of archers (with musicians if points suffice)
When it goes to special units the real deal begins. I\'d definatelly drop silverhelms (I actually never saw any of them since 7\'th ed came) and field some dragonprincess instead.
As for elite infantry it really depends what you are facing. First of all it\'s really pointless to field units of around 15 swordmasters or white lions. Those units are really expensive pointwise and have really marginally bigger hitting power than single line of 7 models. If you field more you just get 1 point to combat resolution for doubling cost of the unit. (we use 7 models to maximize punishment our unit deals to charging enemy with our glorious speed of asuryan). Considering Phoenix guard - they are extremelly tough, but they are not really hardhitting, so you have to base on static combat result to win your fights (static cr is the one you get from ranks banners and stuff) thats why if I\'d field them than i\'d use no less than 20 with full command group and warbanner. Going back to white lions (my fav infantry unit), they are extremelly multipurpose unit. First of all they are really hardhitting, next they are quite tough against shooting, and the most amazing thing stubborn. We can use a small unit of them to stop a charge for a turn and hold the enemy in place for our counter charge. Yet to maximize their potential (if you are playing against fear causing enemy) id give them either lion standard or standard of ballance so they don\'t get fear outnumbered.
To conclude use of elite infantry - i generally recommend to field 2 7-8 models strong units of whitelions with musicians and standard bearers (with former said banners) as this units are really allround and quite cheap pointwise. If you are facing enemy without formidable shooting power then 2 units of 7 swordmasters with musicians are perfest as they can stop and butcher nearly everything. As for phoenix guard, i\'d say they are really situational (I once played a list with 20 of them with warbanner and battlestandard bearer inside, but it was more a fun list)
If you want to field a lion chariot its great but in my opinion little overpriced (I use it because I love the model) Yet if you want to use it really effectivelly then you need some really mobile units like reavers or eagles (or stubborn whitelions) to setup a good charge.
As for rare choices - I use them same as core - to support my elite infantry and dragonprincess, getting rid of enemy shooting, and small pesky units. I\'d say that 2-3 boltthrowers are optimal, and at least 1 great eagle, to block enemy marching and charges, as well as to hunt warmachines and lone wizards.
I hope that my work is readable, and that it will help you a bit. I wrote that from rather a tournament point of viev, but the same principles apply to friendly games.
Also remember that not all things in a list always work as you intended them to, using a list to its fullest is a skill in itself. So go and play, learn from your mistakes and from others succeses.
Hapy gaming,
Adam
PS. sorry for any spelling/grammar mistakes, I just don\'t have time to re-read that and check everything.